fix(parser): restore Bilibili b23.tv short-link redirects - #101
Open
goxofy wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b23.tvshort URLsErrAutoRedirectDisabledsentinel so the parser can inspect the first redirect response and extract itsLocationheaderRoot cause
The proxy-support migration changed Bilibili short-link handling from
net/httpwithhttp.ErrUseLastResponseto Resty'sNoRedirectPolicy().Both approaches intentionally stop automatic redirects so the parser can manually read
Location. However,net/httpreturns the intercepted response without an error, while Resty returnsresty.ErrAutoRedirectDisabledtogether with the response. The existing Bilibili parser treated that expected Resty sentinel as a request failure before readingLocation.Validation
go test ./parser/ -run 'TestBiliBiliGetBvidFrom' -count=1go test ./... -count=1go vet ./...go test -race ./parser/... -count=1b23.tvshare link through the CLI end to end🤖 Generated with Claude Code