Repository navigation
fix(supervise): scheduled prune no longer resets the idle clock (#496) - #533
Merged
Merged
Conversation
… longer resets the idle clock (#496) The prune ran docker through Skrog's own pipe, which stamped LastActivity; a prune.every at or below idle-timeout kept the engine from ever idling. prune.RunAPI executes the same plan against /containers, /images, /volumes and /build prune over the bridge's own transport (shared with the busy probe as engineClient). skrog prune by hand still uses the CLI. The doctor check for the combination is removed: it is no longer a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #496.
The scheduled prune ran
dockerthrough Skrog's own pipe, so each sweep counted as client activity. Withprune.every<=idle-timeoutthe engine never idle-stopped.prune.RunAPI: the samePlan, executed against the engine API (/containers|images|volumes|build/prune), with unit tests incl. volume/until parity with the CLI planengineClientshared withbusyProbe: dials over the bridge transport, not the pipe serverskrog pruneby hand is unchanged (CLI)prune-idledoctor check and the housekeeping.md caveat; CHANGELOG entry addedNot verified against a live engine yet.