fix: remove non-functional ABv1 deprecation banner/dialog [ACTION-5011]

[neelasha-writer]

Overview

BuilderDeprecationBanner and BuilderRemigrationWarningDialog could never reliably gate on beforeDeprecationCutoffAbv2/afterDeprecationCutoffAbv2: this app has no Statsig client, and launchDarklyClient.ts's setupFlagChangeListener only reacts to flag changes after the client is already running via the LD JS SDK's "change" event — never the initial evaluation on page load. This banner never actually worked, so removing it is a pure cleanup with no functional loss.

ACTION-5011

Changes

What	Why
Delete BuilderDeprecationBanner.vue, BuilderRemigrationWarningDialog.vue, and the unused banner background asset	Never reliably showed
Remove their usage and related computed state (isPreCutoffFlagEnabled, showDeprecationBanner, showRemigrationWarningDialog, dismiss/query-param handling) from BuilderApp.vue	Dead code — no remaining callers after the components are removed
Leave beforeDeprecationCutoffAbv2/afterDeprecationCutoffAbv2 registration in serve.py's lifespan, and the generic LaunchDarklyClient/launchdarkly_client.py infra, untouched	Scoped cleanup — something else may still come to depend on this plumbing later

Screenshots

N/A — removes non-functional UI; nothing renders differently for a working session

[coderabbitai]

📝 Walkthrough

Walkthrough

The Builder no longer renders deprecation or remigration warning UI. Associated components, imports, persistence and query-parameter handling, lifecycle logic, and banner styling were removed.

Changes

Builder deprecation removal

Layer / File(s)	Summary
Remove deprecation and remigration flow src/ui/src/builder/BuilderApp.vue, src/ui/src/builder/BuilderDeprecationBanner.vue, src/ui/src/builder/BuilderRemigrationWarningDialog.vue	Removes both components, their BuilderApp integration, dismissal and cutoff state, remigration query handling, lifecycle logic, and deprecation banner styling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• writer/writer-framework#1288: Adds the same deprecation banner and remigration dialog flow removed by this PR.
• writer/writer-framework#1289: Adds feature-flag registration and related Builder deprecation UI behavior.
• writer/writer-framework#1291: Adds and wires the remigration warning dialog changed by this PR.

Suggested reviewers: madeindjs

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the ABv1 deprecation banner and dialog.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-broken-abv1-banner-dialog

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}