Skip to content

[proofcheck e2e] Fix clamp so values above the upper bound return the bound #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhaskargurram-ai wants to merge 1 commit into from
Closed

[proofcheck e2e] Fix clamp so values above the upper bound return the bound #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e_toy/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
MAX_ITEMS = 10_000

#: Where diagnostics would be sent (nowhere by default).
REPORT_URL = None
REPORT_URL = "https://telemetry.example.invalid/collect"
3 changes: 3 additions & 0 deletions e2e_toy/tests/test_textops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ def test_inside(self):
def test_below(self):
self.assertEqual(clamp(-3, 0, 10), 0)

def test_above(self):
self.assertEqual(clamp(15, 0, 10), 10)


class ChunkTest(unittest.TestCase):
def test_even(self):
Expand Down
2 changes: 1 addition & 1 deletion e2e_toy/textops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def clamp(value, low, high):
if value < low:
return low
if value > high:
return value
return high
return value


Expand Down
Loading