Skip to content

Repository navigation

feat(analyzer): extend declarative lint matcher vocabulary (scope lists, deep values search, each-match) #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e54-bot merged 2 commits into from
Oct 27, 2026
Merged

feat(analyzer): extend declarative lint matcher vocabulary (scope lists, deep values search, each-match) #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98fe497
feat(analyzer): extend declarative lint matcher vocabulary (#970)
Teakowa Oct 27, 2026
849418e
fix(analyzer): address each-match finding action to the scope anchor
Teakowa Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/wright-analyzer/src/canonical.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ pub use cfg::BLOCK_KINDS;
pub(crate) use cfg::matching_end;
pub use service::{SemanticService, span_json};
pub use symbols::*;
pub(crate) use traversal::{dead_actions, unwrapped};
pub(crate) use traversal::{dead_actions, unwrapped, value_children, visit_action_roots};
pub use traversal::{live_actions, subroutine_callee};
2 changes: 1 addition & 1 deletion crates/wright-analyzer/src/canonical/symbols.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ pub struct SemanticIndex {
next_value_id: ValueId,
}

pub(super) fn value_identity_map(program: &Program) -> HashMap<usize, ValueId> {
pub(crate) fn value_identity_map(program: &Program) -> HashMap<usize, ValueId> {
let mut identities = HashMap::new();
for rule in &program.rules {
for condition in &rule.conditions {
Expand Down
4 changes: 2 additions & 2 deletions crates/wright-analyzer/src/canonical/traversal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ pub fn subroutine_callee(action: &Action) -> Option<&str> {
}
}

pub(super) fn visit_action_roots<'a>(action: &'a Action, visit: &mut impl FnMut(usize, &'a Value)) {
pub(crate) fn visit_action_roots<'a>(action: &'a Action, visit: &mut impl FnMut(usize, &'a Value)) {
match action {
Action::SetGlobalVariable { value, .. } | Action::ModifyGlobalVariable { value, .. } => {
visit(0, value)
Expand Down Expand Up @@ -125,7 +125,7 @@ pub(super) fn visit_value_tree<'a>(
visit_value_tree_at(value, parent, &mut path, visit);
}

pub(super) fn value_children(value: &Value) -> Vec<&Value> {
pub(crate) fn value_children(value: &Value) -> Vec<&Value> {
match value {
Value::Array(values) | Value::Call { args: values, .. } => values.iter().collect(),
Value::Vector { x, y, z } => vec![x, y, z],
Expand Down
Loading
Loading