Repository navigation
feat(probes): add P9 Set Slow Motion extreme factors - #144
Merged
Merged
Conversation
Measure Total Time Elapsed and Wait at factors 10, 200, 0 and -50 against the hypothesis that Set Slow Motion does not affect the script timeline. The probe has no capture yet (runs: 0). Refs #143
Contributor
Author
|
Verdict: LGTM (head cb23b74) Independent check; I did not write this PR.
Non-blocking notes: (1) the true client minimum is unknown, so 10 may not be "the smallest accepted" that #143 names. If the client clamps, the result shows it as a mismatch or no difference. (2) If factor 0 freezes the simulation, -50 is never measured; the notes already say what to do. The reverse order has the same risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds probe P9 (
probes/p9-slow-motion-extremes) for #143. This PR defines the probe only. The client capture is still owed, so the issue stays open (Refs #143). No simulator code changes.Hypothesis (
expect.json):Set Slow Motionhas no effect on the script timeline at extreme factors.Total Time Elapsedadvances 16 ms per tick andWaitrounds up to whole 16 ms ticks, as at 100%.Factors: 10, 200, 0, -50, in that order. The catalog (
setSlowMotion, oneNumberparameter, no domain) and the wiki text ("must not exceed 100%") document a maximum only. No minimum is documented, so 10 stands as a low positive probe, 0 and -50 test the clamp below it, and 200 tests above the maximum. P8 already measured 50, 90 and the 100 control. Factors 0 and -50 run last because the client may stop the simulation at them, and then the script cannot restore 100.Output: per factor 4
P9mlines (t_ms 16, 32, 48, 64) and 3P9wlines (wait 16, 100, 1000 giving elapsed 16, 112, 1008), thenP9 done: 29 lines. Element count is 120 in both spellings.Owner steps:
probes/p9-slow-motion-extremes/probe.zh-CN.owas the only rule set and start the game. Do not touch the character.P9 doneline (about 20 s of game time), save the log to a file. Repeat for three runs under three file names.athena ingest probes/p9-slow-motion-extremes <log>for each run.Checks:
cargo test,cargo clippy --all-targets -- -D warnings,cargo fmt --check,wright checkon both files. There is no fixture test: P8 has none onmain, and a simulated run needs the P8 model from #139.