You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Model presentation-only and game-mode actions as no-ops (Disable Inspector Recording and class) #103
After #101, Bastion on athena main (docs/scenario-examples/valid/bastion.json, which now carries slot and matchPhase, plus buttons for every slot on both players) ends not_modeled at tick 0:
Rule 187 continues with Disable Built-In Game Mode Completion/Announcer/Music/Scoring, Pause Match Time, Set Slow Motion. Other Bastion rules use more presentation and game-mode actions (Disable Messages, Disable Game Mode HUD, Destroy All Effects, Destroy All HUD Text, Destroy All Icons, Destroy All In-World Text, Destroy All Progress Bar HUD Text, Destroy All Dummy Bots, …). Fixing one stop per run costs a full cycle each, so this issue covers the whole class.
Scope
Audit every action that bastion.ow calls and athena does not yet model (run the workload, and also grep the action names in bastion.ow against the evaluator's supported list). For each, classify with the catalog description as evidence:
No effect on any value a program can read (inspector recording, announcer, music, HUD/effect/icon/text creation or destruction, messages, game-mode HUD, built-in completion/scoring flags that only gate game-mode behavior the simulator does not run): model as a no-op that still records in the trace as an executed action. Record each in docs/findings.md as modeled, not measured, with the catalog sentence as the basis.
Changes a value the program can read or the schedule (for example Pause Match Time vs Match Time/Total Time Elapsed, Set Slow Motion vs timing, Destroy All Dummy Bots vs the player roster): do not guess. Keep not_modeled, and list each in the PR body with the readers it would affect, so a follow-up issue can design it.
Apply the rule per action, not per group. If the catalog text does not settle the class, use category 2.
Acceptance
Tests for each action moved to a no-op: it runs, appears in the trace, and changes no readable value.
Docs: modeled-actions list in docs/simulator-interface.md or wherever actions are enumerated; docs/findings.md entries.
Activity