Merged
Conversation
santostiago
approved these changes
Mar 5, 2026
| @@ -0,0 +1,5 @@ | |||
| class AddShouldChangePasswordToUsers < ActiveRecord::Migration[7.2] | |||
| def change | |||
| add_column :users, :should_change_password, :boolean, default: false, null: false | |||
Contributor
There was a problem hiding this comment.
Is it important to store this?
Isn't it enough to send them an email?
Collaborator
Author
There was a problem hiding this comment.
We have not decided yet how to inform them, maybe periodic email remainder would be good.
| password = auth.env.dig("action_dispatch.request.parameters", "user", "password") | ||
| next unless password | ||
|
|
||
| user.update_column(:should_change_password, true) unless User.strong_password?(password) |
Contributor
There was a problem hiding this comment.
There is no way to move the should_change_password back to false.
If they should change password and then actually change it, this should go to false (it should be added on the model, not here, of course).
Collaborator
Author
There was a problem hiding this comment.
Ahh, right. I will add this. Thanks
… with latest password complexity rules
tsubik
force-pushed
the
feature/flag-weak-passwords
branch
from
d3a856b to
bdf3610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flagging users with passwords that do not comply with current complexity rules.
JIRA: https://gfw.atlassian.net/browse/OPEN-371