Set up npm project - #75
Conversation
- Install np as dev dependency - Add release script to package.json
|
Caution Review failedThe pull request is closed. WalkthroughThe PR introduces a release workflow to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Comment |
Summary of ChangesHello @hideokamoto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initializes the project for streamlined release management by integrating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the np package to automate releases, which is a great addition for managing package publishing.
My review contains one suggestion to make the release script more reliable by ensuring the project is built before publishing.
However, there is a critical issue that will prevent the new release script from working: the repository field is missing in package.json. The np package requires this field to be set, and it will fail without it. Please add the repository field to package.json to ensure the release process works as expected.
| "format": "biome format --write .", | ||
| "prepare": "husky" | ||
| "prepare": "husky", | ||
| "release": "np" |
There was a problem hiding this comment.
The release script should include the build step to ensure that the distribution files are up-to-date before publishing. This prevents accidentally publishing a stale version of your package if you forget to run the build command manually before releasing.
| "release": "np" | |
| "release": "npm run build && np" |
Summary by CodeRabbit