Skip to content

Ignore Java native shared libraries when linking - #313

Merged
Gold856 merged 1 commit into
wpilibsuite:mainfrom
thatcomputerguy0101:ignore-java-dynamic-library
Nov 13, 2026
Merged

Gold856 merged 1 commit into
wpilibsuite:mainfrom
thatcomputerguy0101:ignore-java-dynamic-library

Conversation

@thatcomputerguy0101

@thatcomputerguy0101 thatcomputerguy0101 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

This ignores libraries containing the word java to exclude libopencv_java4130.dylib on macOS, which is a mach-o BUNDLE and can't be passed through ld. Otherwise, linking fails with the error ld: unsupported mach-o filetype (only MH_OBJECT and MH_DYLIB can be linked).

This was previously done through registerStandardDependency, but that code path isn't active any more since the vision libraries are no longer included by default.

This is to exclude `libopencv_java4130.dylib`, which is a mach-o `BUNDLE` and can't be passed through `ld`.
@thatcomputerguy0101 thatcomputerguy0101 changed the title Ignore java native shared libraries Ignore java native shared libraries in vendordeps Nov 13, 2026
@thatcomputerguy0101

Copy link
Copy Markdown
Contributor Author

Tested this cherry picked on top of 2027.14.3, and it worked. It seems like main currently has other unrelated problems.

@thatcomputerguy0101
thatcomputerguy0101 marked this pull request as ready for review November 13, 2026 18:26
@Gold856

Gold856 commented Nov 13, 2026

Copy link
Copy Markdown
Member

Bugs, or just changes that aren’t updated in other places to match? There have been some changes made for beta 1.

@thatcomputerguy0101

Copy link
Copy Markdown
Contributor Author

I think the problem was that I didn't update the robot project's build.gradle from the alpha7 format.

@thatcomputerguy0101

Copy link
Copy Markdown
Contributor Author

Ok, it works with the current main branches too if SystemCore is renamed to Systemcore in the robot project's build.gradle

@Gold856 Gold856 changed the title Ignore java native shared libraries in vendordeps Ignore Java native shared libraries when linking Nov 13, 2026
@Gold856
Gold856 merged commit 394c71d into wpilibsuite:main Nov 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants