Change install directory to ~/.wpilib or XDG_DATA_HOME/wpilib#841
Open
ThadHouse wants to merge 4 commits into
Open
Change install directory to ~/.wpilib or XDG_DATA_HOME/wpilib#841ThadHouse wants to merge 4 commits into
ThadHouse wants to merge 4 commits into
Conversation
Open
4 tasks
| return homeRoot; | ||
|
|
||
| if (isLinux && xdgDataHome != null && !xdgDataHome.isBlank()) { | ||
| return new File(xdgDataHome, ".wpilib"); |
There was a problem hiding this comment.
Suggested change
| return new File(xdgDataHome, ".wpilib"); | |
| return new File(xdgDataHome, "wpilib"); |
(As also mentioned in wpilibsuite/vscode-wpilib#885,) should be wpilib, not .wpilib. Making the folder double-hidden doesn't make sense (and probably violates the spec).
sciencewhiz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On linux, falls back to ~/.wpilib if XDG_DATA_HOME doesn't exist.