Repository navigation
Conversation
- Fix the clippy lints Rust 1.99.1 reports (struct update syntax, repeat_n, as_chunks, iterator loops, a needless to_string, is_empty). - RELOAD_UNCERTAIN is now keyed by config.yaml path, so a test that marks its own file uncertain cannot leak the flag into another test running in parallel. - offline_app points the controller at 127.0.0.1:1, so a worker a test leaves running cannot reach a real core on 127.0.0.1:9090. - networksetup is looked up on PATH, so CI can shadow it with a stub that records and fails any call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pull requests and pushes to main that change code run rustfmt, clippy for Linux, clippy and check for both macOS targets from Linux, tests on Linux and a release build. macOS tests run only on manual runs and on pull requests labelled "macos". The toolchain is pinned to 1.99.1, and the test job fails if anything ran networksetup or gsettings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本 PR 加上 GitHub Actions CI,并把代码修到能通过
cargo clippy -D warnings。CI(
4f0bcd0)*.md、docs/、assets/或LICENSE时跳过。也可以手动运行(workflow_dispatch)。cargo fmt --check;Linux 的 clippy;从 Linux 交叉检查两个 macOS target(aarch64 跑 clippy,x86_64 跑 check)。项目没有 C 依赖,所以不用花 macOS runner 的分钟数。cargo test --all-targets --locked和 release 构建。macOS 测试只在手动运行和带macos标签的 PR 上跑(仓库是私有的,macOS 分钟数按约 10 倍计费)。networksetup和gsettings的替身。替身会记录调用并返回失败;测试之后如果有任何调用记录,job 就失败(AGENTS.md 规定测试不能动系统代理)。clippy 和测试隔离(
d9da523)repeat_n、as_chunks、迭代器循环、多余的to_string、LineEditor::is_empty。RELOAD_UNCERTAIN从全局AtomicBool改成按 config.yaml 路径记录。这样并行测试里,一个测试标记了自己的文件,不会影响别的测试。offline_app把控制器地址设为127.0.0.1:1,测试遗留的 worker 不会连到127.0.0.1:9090上真实的内核。networksetup改为从 PATH 查找(原来是/usr/sbin/networksetup),CI 的替身才能拦截到。其他(
a18e2dd).gitignore忽略 macOS 的 AppleDouble 文件(._*)。验证
cargo fmt --check和cargo clippy --all-targets --locked -- -D warnings通过;cargo test --all-targets --locked331 通过、16 ignored;测试期间替身没有记录到任何networksetup/gsettings调用。macos标签,要在 PR 上跑 macOS 测试需要先创建这个标签。🤖 Generated with Claude Code