Open
Conversation
Replace IOPattern-based transcript with whir's DomainSeparator/ProverState/ VerifierState API (rev 246dae28). Update spongefish to v1.0.0-rc1 with byte-oriented Permutation<64> interface. Proof now carries narg_string + hints instead of a single transcript blob. Key changes: - Sponge: Permutation<64> with U=u8, WIDTH=64, RATE=32 - PoW: PoWSolution return type, solution() method - Prover: config.commit()/config.prove() replacing CommitmentWriter/Prover - Verifier: config.receive_commitment()/config.verify() replacing readers - Public weights use Weights::geometric (non-deferred) on both sides - Cross-evaluation hints for dual-commitment path - NTT registration via global type-map for ark_bn254::Fr - Clippy clean on prover/verifier crates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports provekit to whir's new transcript API from WizardOfMenlo/whir#215 (rev
246dae28). Also bumps spongefish to v1.0.0-rc1.What changed
IOPatternreplaced byDomainSeparator::protocol(config). Proof now carriesnarg_string+hintsinstead of a single transcript blob.Permutation<64>,U=u8) instead of field-element-oriented.CommitmentWriter/Prover/StatementAPI replaced byconfig.commit()/config.prove()/config.verify()with weights + evaluations passed directly.Weights::geometric(non-deferred) — this was the key bug fix during the port.ark_bn254::Frregistered in whir's global type-map viaregister_ntt().SumcheckIOPattern,WitnessIOPattern,witness_io_pattern.rs— no longer needed. Clippy clean on prover/verifier.Tested
Prepare → Prove → Verify on
complete_age_check. Protocol logic unchanged, only the serialization layer is different.