refactor(se050): introduce newtypes for attributes and chip pubkey#1180
Open
refactor(se050): introduce newtypes for attributes and chip pubkey#1180
Conversation
TheButlah
changed the base branch from
main
to
ryanbutler/orbs-1448-nxp-certificate-validation
TheButlah
force-pushed
the
thebutlah/se050-newtypes
branch
from
c586bed to
d68b0c6
Compare
TheButlah
force-pushed
the
ryanbutler/orbs-1448-nxp-certificate-validation
branch
from
32bff8d to
603e3e4
Compare
TheButlah
force-pushed
the
thebutlah/se050-newtypes
branch
from
d68b0c6 to
25e47c8
Compare
Base automatically changed from
ryanbutler/orbs-1448-nxp-certificate-validation
to
main
April 28, 2026 18:30
TheButlah
force-pushed
the
thebutlah/se050-newtypes
branch
from
25e47c8 to
7ab6878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we had too many plain old array types floating around, I wrapped those in a newtype for improved type safety. I also added a newtype for the chip unique pubkey to indicate whether it was actually from a validated cert or not.