feat: IDKit docs improvements — signatures, nullifiers, SDK refs#92
Open
Takaros999 wants to merge 5 commits intomainfrom
Open
feat: IDKit docs improvements — signatures, nullifiers, SDK refs#92Takaros999 wants to merge 5 commits intomainfrom
Takaros999 wants to merge 5 commits intomainfrom
Conversation
…pdates - New `signatures.mdx` page with pseudocode algorithm, JS/Go SDK examples, and cross-language test vectors - Add Step 6 to integration guide: nullifier explanation and PostgreSQL storage guidance - Fix `signRequest` API calls to use v4 options object across integrate and JS reference - Add `return_to` parameter to SDK code examples (JS, Swift, Kotlin) - Expand Go SDK reference with `NewSigner`, `WithAction`/`WithTTL` options - Add signatures page to docs.json navigation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e723b8c350
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…onstraint - Fix pseudocode to conditionally allocate 49 or 81 bytes based on action - Remove trailing comma in PostgreSQL CREATE TABLE example - Add UNIQUE(nullifier, action) constraint to enforce replay protection at DB level Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
andy-t-wang
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/world-id/idkit/signatures) — pseudocode-first algorithm spec with JS/Go SDK examples and cross-language test vectors (verified against both JS and Go test suites)NUMERIC(78, 0)in PostgreSQLsignRequestAPI — updated to v4 options object syntax across integration guide and JS reference; Go example now includesWithActionreturn_toto SDK code examples (JS, Swift, Kotlin)NewSigner,WithAction/WithTTLoptions pattern,RpSignaturestructTest plan
@noble/secp256k1) and Go (dcrd/secp256k1) implementationscspell)🤖 Generated with Claude Code