feat(POP-3811): support World ID bedrock user agents#362
Merged
Guardiola31337 merged 3 commits intoJun 10, 2026
Conversation
Guardiola31337
changed the title
eaypek-tfh
previously approved these changes
Jun 2, 2026
Guardiola31337
requested review from
Dzejkop,
andy-t-wang,
aurel-fr,
karankurbur,
murph,
paolodamico and
sideround
as code owners
Dzejkop
reviewed
Jun 10, 2026
Comment on lines
+76
to
+80
| /// Appends `{client_name}/{os_version}` to match the app client suffix convention. | ||
| #[must_use] | ||
| pub fn with_client_segment(&self, client_name: &str, os_version: &str) -> Self { | ||
| self.with_segment(client_name, os_version) | ||
| } |
There was a problem hiding this comment.
there's no difference to just calling with_segment?
Contributor
There was a problem hiding this comment.
Good catch — you're right, with_client_segment was a pure passthrough to with_segment(client_name, os_version) with no transformation. Removed it and updated the test helper to call with_segment directly (0998b19).
Contributor
Author
|
/otto can you please address the comments? 🙏 Feel free to use gpt-5.5 as model |
Contributor
|
I've spawned a GPT-5.5 subagent to address Dzejkop's review comment. It will:
I'll update you once it's done! 🙏 |
Contributor
|
Respawned with Claude Opus 4.7 — GPT-5.5 hit a quota limit. The new agent is picking up where we left off. I'll update you once it completes! 🙏 |
Per review feedback: with_client_segment was a pure passthrough to with_segment with no transformation. Removed it and updated the test helper to call with_segment directly.
Contributor
|
The review comment has been addressed! ✅ Here's what was done:
|
Contributor
Author
|
/otto looks like |
Contributor
|
On it — spawning an agent to add an ignore entry for |
Contributor
|
Fixed the
Verified locally with |
Contributor
|
All fixed! ✅ Here's what was done:
CI should be green on the next run. |
Dzejkop
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WorldAppheaders while World ID clients can sendWorldIDheaders.Changes
UserAgentandUserAgentBuilderprimitives.android-id/ios-idclient names toWorldID; keep all other client names onWorldApp.bedrock.Testing Instructions
cargo fmt --checkcargo test -p bedrock user_agent --libcargo clippy --all-targets --all-features -- -D warnings./kotlin/build_kotlin.sh./build_android_local.sh 0.2.14-SNAPSHOTcargo test -p bedrock --lib; the ERC4626 tests require localanvil, which is not installed in this environment. Non-anvil tests passed before that blocker.Note
Low Risk
New optional HTTP metadata helpers with no auth or wallet logic changes; deny.toml only suppresses a transitive unmaintained-crate advisory.
Overview
Adds UniFFI-exported
UserAgentandUserAgentBuilderprimitives so Bedrock consumers can build consistent HTTPUser-Agentheaders. The builder supports arbitraryname/versionsegments plus helpers for app version,bedrock/{crate version}, and client/OS suffixes.World ID vs World App:
with_app_segment_for_clientusesWorldID/{version}whenclient_nameisandroid-idorios-id, andWorldApp/{version}for all other clients (e.g.android,ios).UserAgent::header_value()exposes the final string for FFI.The new types are wired through
primitives::user_agentand re-exported at the crate root alongside the HTTP client types. Unit tests cover empty builds, segment ordering, and each client/product combination.Also adds a cargo-deny advisory ignore for
RUSTSEC-2026-0173(proc-macro-error2viaalloy), with no dependency upgrade in this PR.Reviewed by Cursor Bugbot for commit cc3138d. Bugbot is set up for automated code reviews on this repo. Configure here.