Skip to content

Conversation

@owenvoke
Copy link
Member

This resolves an issue where multi-line array shapes were being unnecessarily modified.

This resolves an issue where multi-line array shapes were being unnecessarily modified.
@owenvoke owenvoke requested review from a team, Copilot and odinns October 16, 2025 11:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fix multi-line array shape handling by preventing unnecessary space normalization across line breaks in generics.

  • Update the fixer to use PhpCsFixer\Preg with regex that avoids adding spaces after commas when followed by a newline.
  • Process annotations via getTypes()/setTypes() to handle multiple types uniformly.
  • Add a test covering multi-line array shapes; bump ECS dev dependency to ^12.6.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/PhpCsFixer/SpaceInGenericsFixerTest.php Adds a test ensuring multi-line array shapes aren’t modified incorrectly.
src/PhpCsFixer/SpaceInGenericsFixer.php Adjusts spacing logic using PhpCsFixer\Preg and updates annotation handling to map over types.
composer.json Bumps symplify/easy-coding-standard from ^12.5 to ^12.6 for tooling compatibility.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@owenvoke owenvoke merged commit e3e1ab7 into main Oct 16, 2025
6 checks passed
@owenvoke owenvoke deleted the JIRA-16017_multi-line-array-shapes branch October 16, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants