Migrate FetchAllDomainsUseCase and domain management UI from FluxC to wordpress-rs#22900
Draft
oguzkocer wants to merge 2 commits into
Draft
Migrate FetchAllDomainsUseCase and domain management UI from FluxC to wordpress-rs#22900oguzkocer wants to merge 2 commits into
FetchAllDomainsUseCase and domain management UI from FluxC to wordpress-rs#22900oguzkocer wants to merge 2 commits into
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
Project dependencies changeslist! Upgraded Dependencies
rs.wordpress.api:android:trunk-99776d6504632951fe57fa044d26612d13a1629b, (changed from trunk-e72723b903746f1505c8f0df1e3634dfa50e2d36)
rs.wordpress.api:kotlin:trunk-99776d6504632951fe57fa044d26612d13a1629b, (changed from trunk-e72723b903746f1505c8f0df1e3634dfa50e2d36)tree +--- project :libs:fluxc
-| \--- rs.wordpress.api:android:trunk-e72723b903746f1505c8f0df1e3634dfa50e2d36
-| +--- com.squareup.okhttp3:okhttp:5.3.2 (*)
-| +--- com.squareup.okhttp3:okhttp-tls:5.3.2
-| | +--- com.squareup.okhttp3:okhttp:5.3.2 (*)
-| | +--- com.squareup.okio:okio:3.16.4 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 -> 2.3.21 (*)
-| +--- net.java.dev.jna:jna:5.18.1
-| +--- rs.wordpress.api:kotlin:trunk-e72723b903746f1505c8f0df1e3634dfa50e2d36
-| | +--- com.squareup.okhttp3:okhttp:5.3.2 (*)
-| | +--- com.squareup.okhttp3:okhttp-tls:5.3.2 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 -> 1.11.0 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.3.21 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.3.21 (*)
+| \--- rs.wordpress.api:android:trunk-99776d6504632951fe57fa044d26612d13a1629b
+| +--- com.squareup.okhttp3:okhttp:5.3.2 (*)
+| +--- com.squareup.okhttp3:okhttp-tls:5.3.2
+| | +--- com.squareup.okhttp3:okhttp:5.3.2 (*)
+| | +--- com.squareup.okio:okio:3.16.4 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 -> 2.3.21 (*)
+| +--- net.java.dev.jna:jna:5.18.1
+| +--- rs.wordpress.api:kotlin:trunk-99776d6504632951fe57fa044d26612d13a1629b
+| | +--- com.squareup.okhttp3:okhttp:5.3.2 (*)
+| | +--- com.squareup.okhttp3:okhttp-tls:5.3.2 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 -> 1.11.0 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.3.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.3.21 (*)
-\--- rs.wordpress.api:android:trunk-e72723b903746f1505c8f0df1e3634dfa50e2d36 (*)
+\--- rs.wordpress.api:android:trunk-99776d6504632951fe57fa044d26612d13a1629b (*) |
Contributor
|
|
Contributor
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22900 +/- ##
==========================================
- Coverage 37.33% 37.33% -0.01%
==========================================
Files 2319 2319
Lines 124674 124746 +72
Branches 16951 16963 +12
==========================================
+ Hits 46551 46571 +20
- Misses 74361 74416 +55
+ Partials 3762 3759 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…to wordpress-rs Replace FluxC's `SiteStore.fetchAllDomains()` with direct wordpress-rs API call via `WpComApiClient.domains().allDomains()`. - `FetchAllDomainsUseCase` now uses wordpress-rs instead of `SiteStore` - `DomainManagementViewModel` uses `AllDomainItem` instead of `AllDomainsDomain` - `DomainsDashboardViewModel` updated for the shared `FetchAllDomainsUseCase` change - `DomainLocalSearchEngine` and `GetDomainDetailsUrl` adapted for `AllDomainItem` - Status color mapping uses `DomainListItemStatusType` instead of `StatusType` - Compose previews updated for wordpress-rs types - Bump wordpress-rs to include `Alert`/`Neutral`/`Premium` status type variants
Bump wordpress-rs to pick up the `SiteRedirect` variant and replace
the `Other("redirect")` workaround in `GetDomainDetailsUrl`.
97f07de to
e048efc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Replace FluxC's
SiteStore.fetchAllDomains()and related domain management types with direct wordpress-rs API calls:WpComApiClient.domains().allDomains()FetchAllDomainsUseCasenow uses wordpress-rs instead ofSiteStoreDomainManagementViewModelusesAllDomainIteminstead ofAllDomainsDomainDomainsDashboardViewModelupdated for the sharedFetchAllDomainsUseCasechangeDomainLocalSearchEngineandGetDomainDetailsUrladapted forAllDomainItemDomainListItemStatusTypeinstead ofStatusTypeSiteRedirectsubtype andAlert/Neutral/Premiumstatus type variantsTesting instructions
Me > Domainslist screen before and after this change.