Intercept touch event to task list checkboxes to handle it before the cursor is moved#1096
Merged
Intercept touch event to task list checkboxes to handle it before the cursor is moved#1096
Conversation
…id into improve-checkboxes
khaykov
approved these changes
Jan 27, 2025
| x, | ||
| totalPaddingStart | ||
| ) == true) { | ||
| refreshText() |
Contributor
There was a problem hiding this comment.
I had a whole bunch of code here that was supposed to preserve a cursor, but the only thing that was actually doing was just passing false into refreshText.
Suggested change
| refreshText() | |
| refreshText(false) |
Contributor
Author
There was a problem hiding this comment.
Man, that is what happens when you don't read the method's signature. Thank you for the pointer.
Contributor
Author
|
Thank you for the recommendation @khaykov, I implemented both changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
This PR improves the UX of task lists checkboxes touch events. The changes are a little hacky but that is how the current solution to work with checkboxes work currently.
Test
Review
@planarvoid
Make sure strings will be translated:
strings.xmlas a part of the integration PR.