Repository navigation
utils: tie-break equal output indices instead of throwing - #187
Open
aleksraiden wants to merge 1 commit into
Open
aleksraiden wants to merge 1 commit into
aleksraiden wants to merge 1 commit into
Conversation
vout_before threw when two outputs shared account, subaddress and local index, although std::sort may compare any two elements. The comment already promised a key-image tie-break; implement it, fall back to the transaction hash, and compare equal outputs as equal.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash in
get_outputs()on a real wallet with many outputs.vout_beforethrewShould never sort outputs with duplicate indiceswhen two outputs had the same account, subaddress and local index.std::sortmay compare any two elements; a comparator that throws is not a valid ordering, and the comment above the code already promised a key-image tie-break that was missing.The comparator now uses the key image hex, then the transaction hash, and returns
falsefor two truly identical outputs. This keeps a strict weak ordering and unblockswallet.getOutputs()— and with it freeze/thaw and output queries.Reproduction and root-cause notes: aleksraiden/monero-ts#1