Preserve GPT-Control response polling state - #48
Open
wolfiesch wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small and well-tested, and it directly addresses the incorrect state transition that cleared awaitingAssistant without observing a new assistant turn.
Pull request overview
This PR fixes GPT-Control assistant polling so the driver preserves the “awaiting assistant response” state until a new assistant turn is actually observed, avoiding prematurely clearing the waiting flag when repeated polls still see the previous assistant message.
Changes:
- Introduces
nextAssistantProgressto centralize and correctly compute assistant progress updates based on fingerprint changes. - Refactors
readAssistantto update persisted session metadata only when the assistant fingerprint changes (preservingawaitingAssistantacross unchanged polls). - Adds unit tests covering the key polling/progress transitions.
File summaries
| File | Description |
|---|---|
| packages/gpt-control-driver/src/driver.ts | Adds nextAssistantProgress and updates readAssistant to avoid clearing awaitingAssistant unless the assistant fingerprint changes. |
| packages/gpt-control-driver/test/driver.test.ts | Adds focused unit tests validating nextAssistantProgress behavior for unchanged fingerprints, new turns, and baseline recording. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.