Skip to content

Preserve GPT-Control response polling state - #48

Open
wolfiesch wants to merge 1 commit into
mainfrom
fix/gpt-control-awaiting-assistant
Open

Preserve GPT-Control response polling state#48
wolfiesch wants to merge 1 commit into
mainfrom
fix/gpt-control-awaiting-assistant

Conversation

@wolfiesch

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings September 1, 2026 04:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small and well-tested, and it directly addresses the incorrect state transition that cleared awaitingAssistant without observing a new assistant turn.

Pull request overview

This PR fixes GPT-Control assistant polling so the driver preserves the “awaiting assistant response” state until a new assistant turn is actually observed, avoiding prematurely clearing the waiting flag when repeated polls still see the previous assistant message.

Changes:

  • Introduces nextAssistantProgress to centralize and correctly compute assistant progress updates based on fingerprint changes.
  • Refactors readAssistant to update persisted session metadata only when the assistant fingerprint changes (preserving awaitingAssistant across unchanged polls).
  • Adds unit tests covering the key polling/progress transitions.
File summaries
File Description
packages/gpt-control-driver/src/driver.ts Adds nextAssistantProgress and updates readAssistant to avoid clearing awaitingAssistant unless the assistant fingerprint changes.
packages/gpt-control-driver/test/driver.test.ts Adds focused unit tests validating nextAssistantProgress behavior for unchanged fingerprints, new turns, and baseline recording.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants