Fix TypeErrors - #2
Open
jchnkl wants to merge 1 commit into
Open
Conversation
jchnkl
commented
Jun 14, 2021
- Use bytes-like objects instead of str
- basestring does not exist in python 3
* Use bytes-like objects instead of str * basestring does not exist in python 3
Owner
|
Thanks for your PR. I've mostly abandoned this code since I haven't been suing wpactrl for quite some time, so it's much appreciated that you're contributing with some P3 compatibility. However, you've changed the return of the wpa_ctrl_attach_helper to return False if socket return is not "OK". This breaks with for instance socket timeouts which returns -2 from wpa_ctrl_request. I'd appreciate if you could change it back to return ret, then I'd gladly accept it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.