Skip to content

Fix TypeErrors - #2

Open
jchnkl wants to merge 1 commit into
wolfhechel:masterfrom
jchnkl:master
Open

Fix TypeErrors#2
jchnkl wants to merge 1 commit into
wolfhechel:masterfrom
jchnkl:master

Conversation

@jchnkl

@jchnkl jchnkl commented Jun 14, 2021

Copy link
Copy Markdown
  • Use bytes-like objects instead of str
  • basestring does not exist in python 3

* Use bytes-like objects instead of str
* basestring does not exist in python 3
@wolfhechel

Copy link
Copy Markdown
Owner

Thanks for your PR. I've mostly abandoned this code since I haven't been suing wpactrl for quite some time, so it's much appreciated that you're contributing with some P3 compatibility.

However, you've changed the return of the wpa_ctrl_attach_helper to return False if socket return is not "OK". This breaks with for instance socket timeouts which returns -2 from wpa_ctrl_request. I'd appreciate if you could change it back to return ret, then I'd gladly accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants