Repository navigation
fix(extension): binary direct fallback no longer decodes the body to text - #54
Merged
Merged
Conversation
…text Videos over ~48 MB pass Chrome's message limit as base64, so they take compat.js's direct fallback. That path always set responseText, holding a decoded copy of the whole file that nothing reads. It now matches the proxy path: a binary reply carries only the ArrayBuffer. Fixes #53 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.
A binary response over ~48 MB passes Chrome's 64 MiB message limit as base64, so
compat.jsfalls back todirectHttpRequest. That function always decoded the body intoresponseText, which for a 52 MB video is a ~52-million-character string nothing reads. It now returns only the ArrayBuffer forresponseType: 'arraybuffer', the same contract as the proxy path since #13. Both userscript readers ofresponseTextrequest text.test/extension.test.mjs(failed before the fix).responseText. Before the change the same call returnedresponseTextset.🤖 Generated with Claude Code