Repository navigation
fix(launcher): stop relying on --load-extension for Google Chrome - #45
Merged
Merged
Conversation
Branded Google Chrome 137+ ignores --load-extension. When the launcher picked Chrome, its shortcut and -Status looked healthy while the extension never loaded, and the CLI could not reach the host. The launcher now detects branded Chrome by product name (Chromium and Chrome for Testing also ship chrome.exe and still honor the flag). On Chrome it leaves the flag out, asks for a one-time Load unpacked, keeps the occlusion flag, and checks only that flag in -Status. Edge is preferred over Chrome. -ShowLaunchArgs prints what would run, and the native host test drives it with stand-in browser exes. Refs #44 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #44. Branded Google Chrome 137+ ignores
--load-extension, and the launcher handed Chrome that flag anyway. The shortcut and-Statusreported healthy while the extension never loaded.Change
VersionInfo.ProductName -eq 'Google Chrome'. Chromium and Chrome for Testing ship achrome.exetoo and still honor the flag.--load-extensionout, prints the one-time Load unpacked steps, and still passes--disable-features=CalculateNativeWinOcclusion.-Statuschecks only that flag, since an unpacked extension does not show on a command line.-ShowLaunchArgsprints the browser and arguments without changing anything.Verification
test/native-host.test.mjsbuilds stand-in exes for Google Chrome, Chrome for Testing and Edge, and checks the launch arguments of each (Windows only; skipped on CI's Linux runner). Before the fix the test failed withChrome must not be given --load-extension.-Statusexits 0 and-ShowLaunchArgsstill includes--load-extension.🤖 Generated with Claude Code