do not enable TLSX with --enable-ech#10153
Open
sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
Open
do not enable TLSX with --enable-ech#10153sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the implicit --enable-tlsx activation from --enable-ech to avoid pulling in the full “all TLS extensions” bundle (and its side-effects like forcing Truncated HMAC), while keeping the actual ECH prerequisites enabled via TLS 1.3.
Changes:
- Stop
--enable-echfrom auto-enabling--enable-tlsx. - Keep ECH prerequisites enabled explicitly (HPKE, ECC/Curve25519, SHA-256, SNI, TLS 1.3).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--enable-ech was pulling in --enable-tlsx, which enables all TLS extensions in bulk. ECH does not need most of these.
The --enable-tlsx dependency was redundant to begin with. HAVE_TLS_EXTENSIONS, the only thing ECH actually needs from it, is already provided by --enable-tls13, which ECH already enables directly.
Removing the line fixes the --enable-ech --enable-harden-tls combination without affecting any ECH functionality. Thus solving GH #10067.
Checklist