Skip to content

20260407-BLAKE-gating#10152

Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
douzzer:20260407-BLAKE-gating
Apr 7, 2026
Merged

20260407-BLAKE-gating#10152
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
douzzer:20260407-BLAKE-gating

Conversation

@douzzer
Copy link
Copy Markdown
Contributor

@douzzer douzzer commented Apr 7, 2026

globally fix all "BLAKE2" references (implicit BLAKE2B) to explicit "BLAKE2B":

  • implement legacy compatibility in settings.h and configure.ac (adds --enable-blake2b while retaining --enable-blake2);
  • fix incorrect Blake2 gates in wolfcrypt/src/hash.c wc_HashGetDigestSize() and wc_HashGetBlockSize();
  • in wolfcrypt/test/test.c hash_test(), backfill missing Blake2 test coverage and separate blake2b from blake2s in typesHashBad[];
  • in tests/api/test_hash.c, separate blake2b from blake2s in notCompiledHash[], sizeSupportedHash[], and sizeNotCompiledHash[].

tested with

wolfssl-multi-test.sh ...
super-quick-check
wolfssl-plus-wireguard

(detected by wolfssl-plus-wireguard)

…BLAKE2B":

* implement legacy compatibility in settings.h and configure.ac (adds --enable-blake2b while retaining --enable-blake2);
* fix incorrect Blake2 gates in wolfcrypt/src/hash.c wc_HashGetDigestSize() and wc_HashGetBlockSize();
* in wolfcrypt/test/test.c hash_test(), backfill missing Blake2 test coverage and separate blake2b from blake2s in typesHashBad[];
* in tests/api/test_hash.c, separate blake2b from blake2s in notCompiledHash[], sizeSupportedHash[], and sizeNotCompiledHash[].
@douzzer douzzer added the For This Release Release version 5.9.1 label Apr 7, 2026
@douzzer douzzer requested a review from Frauschi April 7, 2026 18:36
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10152

Scan targets checked: wolfcrypt-api_misuse, wolfcrypt-bugs, wolfcrypt-compliance, wolfcrypt-concurrency, wolfcrypt-consttime, wolfcrypt-defaults, wolfcrypt-mutation, wolfcrypt-port, wolfcrypt-port-bugs, wolfcrypt-portability, wolfcrypt-proptest, wolfcrypt-src, wolfcrypt-zeroize, wolfssl-bugs, wolfssl-compliance, wolfssl-consttime, wolfssl-defaults, wolfssl-mutation, wolfssl-proptest, wolfssl-src, wolfssl-zeroize

No new issues found in the changed files. ✅

Copy link
Copy Markdown
Contributor

@Frauschi Frauschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacobBarthelmeh JacobBarthelmeh merged commit 7f84fb2 into wolfSSL:master Apr 7, 2026
506 of 509 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants