Use $(DefaultPlatformToolset) in wolfssl.vcxproj#10151
Use $(DefaultPlatformToolset) in wolfssl.vcxproj#10151julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Replace the hardcoded v110 platform toolset with $(DefaultPlatformToolset) to improve compatibility across different Visual Studio versions.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Visual Studio project to avoid pinning the build to a legacy toolset by using the default toolset configured for the current VS/MSBuild environment.
Changes:
- Replaced hardcoded
v110toolset with$(DefaultPlatformToolset)across all configurations. - Normalized the XML header line (removing leading whitespace/BOM in the diff) and adjusted formatting/line endings in the touched block.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration"> | ||
| <ConfigurationType>StaticLibrary</ConfigurationType> | ||
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
| <WholeProgramOptimization>true</WholeProgramOptimization> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|Win32'" Label="Configuration"> | ||
| <ConfigurationType>DynamicLibrary</ConfigurationType> | ||
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
| <WholeProgramOptimization>true</WholeProgramOptimization> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration"> | ||
| <ConfigurationType>StaticLibrary</ConfigurationType> | ||
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
| <WholeProgramOptimization>true</WholeProgramOptimization> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|x64'" Label="Configuration"> | ||
| <ConfigurationType>DynamicLibrary</ConfigurationType> | ||
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
| <WholeProgramOptimization>true</WholeProgramOptimization> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'" Label="Configuration"> | ||
| <ConfigurationType>StaticLibrary</ConfigurationType> | ||
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
| <WholeProgramOptimization>true</WholeProgramOptimization> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|ARM64'" Label="Configuration"> | ||
| <ConfigurationType>DynamicLibrary</ConfigurationType> | ||
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> |
There was a problem hiding this comment.
<PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> is repeated in every configuration block. Since it’s identical everywhere, consider defining it once (e.g., in a single unconditional PropertyGroup after importing Microsoft.Cpp.Default.props) or omitting PlatformToolset entirely to let Visual Studio/MSBuild choose the default. This reduces duplication and lowers the chance of future config drift.
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration"> | |
| <ConfigurationType>StaticLibrary</ConfigurationType> | |
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|Win32'" Label="Configuration"> | |
| <ConfigurationType>DynamicLibrary</ConfigurationType> | |
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration"> | |
| <ConfigurationType>StaticLibrary</ConfigurationType> | |
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|x64'" Label="Configuration"> | |
| <ConfigurationType>DynamicLibrary</ConfigurationType> | |
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'" Label="Configuration"> | |
| <ConfigurationType>StaticLibrary</ConfigurationType> | |
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|ARM64'" Label="Configuration"> | |
| <ConfigurationType>DynamicLibrary</ConfigurationType> | |
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | |
| <PropertyGroup> | |
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration"> | |
| <ConfigurationType>StaticLibrary</ConfigurationType> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|Win32'" Label="Configuration"> | |
| <ConfigurationType>DynamicLibrary</ConfigurationType> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration"> | |
| <ConfigurationType>StaticLibrary</ConfigurationType> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|x64'" Label="Configuration"> | |
| <ConfigurationType>DynamicLibrary</ConfigurationType> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'" Label="Configuration"> | |
| <ConfigurationType>StaticLibrary</ConfigurationType> | |
| <CharacterSet>Unicode</CharacterSet> | |
| <WholeProgramOptimization>true</WholeProgramOptimization> | |
| </PropertyGroup> | |
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DLL Release|ARM64'" Label="Configuration"> | |
| <ConfigurationType>DynamicLibrary</ConfigurationType> |
| <CharacterSet>Unicode</CharacterSet> | ||
| </PropertyGroup> | ||
| <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" /> | ||
| <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" /> |
There was a problem hiding this comment.
The touched block appears to have switched line endings/formatting (the added lines show CRLF in the diff). Mixing line endings within a project file can create noisy diffs and tooling inconsistencies; it’s best to normalize the entire file to the repo’s standard (often via .gitattributes or an editorconfig setting) rather than partially changing only the edited region.
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
| </PropertyGroup> | ||
| <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" /> |
There was a problem hiding this comment.
The touched block appears to have switched line endings/formatting (the added lines show CRLF in the diff). Mixing line endings within a project file can create noisy diffs and tooling inconsistencies; it’s best to normalize the entire file to the repo’s standard (often via .gitattributes or an editorconfig setting) rather than partially changing only the edited region.
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
This PR is described as only changing the platform toolset, but the diff also includes an XML prolog change (whitespace/BOM/formatting). If this is intentional, it would help to mention it in the PR description; if not, consider reverting the encoding/formatting change to keep the PR focused and reduce churn.
Replace the hardcoded v110 platform toolset with $(DefaultPlatformToolset) to improve compatibility across different Visual Studio versions.