Guard OCSP signature params with WC_RSA_PSS ifdef

[julek-wolfssl]

OCSPBASICRESPASN_IDX_SIGNATURE_PARAMS is only defined when WC_RSA_PSS
is enabled but was used unconditionally in EncodeBasicOcspResponse,
causing a build error when WC_RSA_PSS is not defined.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes a conditional-compilation build break in OCSP basic response encoding when WC_RSA_PSS is disabled by guarding usage of OCSPBASICRESPASN_IDX_SIGNATURE_PARAMS.

Changes:

• Wraps signature-parameter ASN.1 encoding in EncodeBasicOcspResponse() with #ifdef WC_RSA_PSS.

Comments suppressed due to low confidence (3)

wolfcrypt/src/asn.c:1

• When WC_RSA_PSS is not enabled, this change will silently omit encoding sigParams even if the caller provides them (or if the signature OID implies RSA-PSS). That can produce a non-compliant AlgorithmIdentifier for RSA-PSS (parameters are required by spec) and make the encoded OCSP response unverifiable by strict parsers. Consider adding an #else path that returns a clear error (e.g., “not compiled in”) when resp->sigParams is set (or when resp->sigOID indicates PSS) so misconfiguration fails fast rather than emitting subtly invalid ASN.1.
  wolfcrypt/src/asn.c:1
• Preprocessor directives are typically aligned to the start of the line in this file style (no indentation). Using #ifdef/#endif at column 1 improves readability and reduces the chance of inconsistent formatting in future edits.
  wolfcrypt/src/asn.c:1
• Preprocessor directives are typically aligned to the start of the line in this file style (no indentation). Using #ifdef/#endif at column 1 improves readability and reduces the chance of inconsistent formatting in future edits.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[julek-wolfssl]

retest this please history lost

[julek-wolfssl]

Failures not related to PR