Skip to content

scheduler: ignore RecvError::Lagged #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuyuyureka merged 2 commits into from
Mar 30, 2026
Merged

scheduler: ignore RecvError::Lagged #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375ba27
main: print scheduler error
yuyuyureka Mar 30, 2026
bfcb5f9
scheduler: ignore RecvError::Lagged
yuyuyureka Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vicky/src/bin/vicky/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ async fn inner_main() -> Result<()> {
select! {
e = web_task => e.map(|_| ()).context(startup::JoinErr)?,
_ = task_timeout_sweeper => panic!("Task timeout sweeper shouldn't exit"),
_ = scheduler_join_handle => panic!("Scheduler shouldn't exit"),
e = scheduler_join_handle => panic!("Scheduler shouldn't exit. Returned: {:?}", e),
}

Ok(())
Expand Down
6 changes: 4 additions & 2 deletions vicky/src/lib/vicky/scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,10 @@ impl Scheduler {
tokio::select! {
res = global_events_rx.recv() => {
// wait for changed or new tasks...
if res.is_err() {
return Err(SchedulerError::ChannelClosed.into());
match res {
Ok(_) => {},
Err(tokio::sync::broadcast::error::RecvError::Lagged(_)) => {},
Err(_) => return Err(SchedulerError::ChannelClosed.into()),
}
}
res = fairy_handles_rx.recv() => {
Expand Down
Loading