Harden pool timing fidelity for record command - #62
Merged
Conversation
RecordingScraper stamps each call's t with time.perf_counter() instead of time.time(), so frame-latency and cadence math is monotonic and high-resolution. The header created_at stays wall-clock. Signed-off-by: Paulo Santos <pauloxrms@gmail.com>
The polling thread now sleeps the remainder of the period after the read burst (max(0, period - elapsed)) rather than a full period on top of the read time, so the poll cadence tracks the requested period. When the reads already exceed the period, polls run back-to-back. Signed-off-by: Paulo Santos <pauloxrms@gmail.com>
Signed-off-by: Paulo Santos <pauloxrms@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording often caused the requested pediod to be added to reading time, causing less frames than expected to be captured. Make the sleep timer acount for time spent reading the target.