Skip to content

fix: notify before reporting maker cleanup failure #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wjllance wants to merge 1 commit into from
Closed

fix: notify before reporting maker cleanup failure #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions crates/standx-cli/src/commands/maker/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,9 +778,15 @@ async fn run_maker(symbol: String, args: MakerRunArgs, output_format: OutputForm
if let Some(handle) = order_response_handle {
handle.abort();
}
if args.live {
cancel_maker_orders_with_retry(&client, &symbol, 3).await?;
}
// Do not return early on cleanup failure: operators need the stopped
// lifecycle alert most when residual maker orders may still be live.
let cleanup_error = if args.live {
cancel_maker_orders_with_retry(&client, &symbol, 3)
.await
.err()
} else {
None
};

// Notify stop on every exit path. Await delivery so the message lands
// before the process exits.
Expand All @@ -791,16 +797,20 @@ async fn run_maker(symbol: String, args: MakerRunArgs, output_format: OutputForm
let pnl_str = last_mark
.map(|m| format!("{:+.2}", stats.mark_to_market(m)))
.unwrap_or_else(|| "n/a".to_string());
let cleanup_note = cleanup_error.as_ref().map_or_else(String::new, |error| {
format!(" | ⚠️ cleanup failed: {error}")
});
notify_lifecycle(
"stopped",
&format!(
"🔴 maker stopped ({}) — {} | {} cycles, {} fills, uptime {:.0}%, PnL {}",
"🔴 maker stopped ({}) — {} | {} cycles, {} fills, uptime {:.0}%, PnL {}{}",
reason,
symbol,
cycle,
total_fills,
stats.uptime_pct(),
pnl_str
pnl_str,
cleanup_note,
),
&symbol,
output_format,
Expand All @@ -811,6 +821,13 @@ async fn run_maker(symbol: String, args: MakerRunArgs, output_format: OutputForm
)
.await;

if let Some(error) = cleanup_error {
return Err(anyhow::anyhow!(
"maker stopped but maker-owned order cleanup failed: {}",
error
));
}

match exit {
MakerExit::CtrlC => Ok(()),
MakerExit::FailSafe(e) => Err(anyhow::anyhow!(
Expand Down