Skip to content

Conversation

@ericpsimon
Copy link
Contributor

Summary

Implements NAPI bindings for the core validation API, exposing ValidationSuite, Check, and related types to TypeScript.

Implementation Details

Core Modules Added:

  • src/types.rs: Type conversions and enums (Level, ConstraintStatus, ValidationResult, etc.)
  • src/check.rs: Check and CheckBuilder with various constraint methods
  • src/validation_suite.rs: ValidationSuite and builder with async run capability
  • src/data_source.rs: DataSource abstraction supporting CSV, Parquet, and JSON
  • src/lib.rs: Main NAPI module setup and exports

Key Features:

✅ ValidationSuite can be created from TypeScript
✅ Check builder pattern works in TypeScript
✅ Async run() method properly returns Promise
✅ Error handling converts Rust errors to JS exceptions
✅ TypeScript definitions are correctly generated
✅ Basic validation suite can be built and executed

TypeScript API:

// Create data source
const data = await DataSource.fromCsv('data.csv');

// Build checks
const check = new CheckBuilder('completeness')
  .level(Level.Error)
  .isComplete('column', 0.95);

// Create validation suite
const suite = ValidationSuite.builder('my_suite')
  .addCheck(check)
  .build();

// Run validation
const result = await suite.run(data);

Test Coverage

  • Basic module functions
  • Level enum exports
  • CheckBuilder configuration and creation
  • ValidationSuite builder pattern
  • DataSource creation from CSV/Parquet/JSON
  • Full end-to-end validation workflow
  • Error handling

Linear Ticket

Implements: TER-345

🤖 Generated with Claude Code

- Moved all Node.js binding files from term-guard-node/ to node/term-guard/
- Updated Cargo.toml workspace configuration
- Fixed term-guard dependency path in node/term-guard/Cargo.toml
- Updated GitHub Actions workflow paths
- Added proper .gitignore for Node.js dependencies and build artifacts
- Simplified NAPI CI workflow:
  - Removed matrix builds (out of scope for this project)
  - Single Linux build for development
  - Combined build and test into one job
  - Only upload artifacts from main branch
- Updated to use npm instead of yarn
- Aligned with project CI patterns
- Convert index.js to index.ts with proper TypeScript types
- Convert test/index.test.js to test/index.test.ts with interfaces
- Add comprehensive TypeScript type definitions in index.d.ts
- Update package.json to use TypeScript compilation pipeline
- Configure tsconfig.json for CommonJS module output
- Update build scripts to compile TypeScript before NAPI build
- Add tsx for running TypeScript tests directly
- Update .gitignore and .npmignore for TypeScript workflow
- Remove old JavaScript files in favor of TypeScript
- Implement ValidationSuite and Check NAPI bindings
- Add DataSource abstraction for CSV, Parquet, and JSON
- Create TypeScript type definitions
- Add comprehensive test coverage
- Enable builder pattern for Check and ValidationSuite
- Support async validation execution with performance metrics

Implements: TER-345
@ericpsimon ericpsimon force-pushed the 10-04-feat_ter-345_implement_core_validation_api_bindings_for_node.js branch from 448fe13 to 3ace505 Compare October 9, 2025 21:11
@ericpsimon
Copy link
Contributor Author

Closing as duplicate. This PR is now properly stacked as #55 which targets the 10-03 branch.

@ericpsimon ericpsimon closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants