Repository navigation
feat: what a client can ask a decoder and a context - #156
Merged
Merged
Conversation
The additive half of #152's list: a transport that reports its losses, or sets the share of frames drawn in part from them, could not ask how many blocks of a frame had arrived; and a program could learn a context's GPU only from a string meant for people. - Decoder::received_blocks and total_blocks in Rust, the browser player's received_blocks and total_blocks, and emberwave_decoder_reception in the C API, which also says whether the start of frame header arrived. - emberwave_context_info: the backend, the kind of device, the PCI vendor and device, and which call made the context, with EMBERWAVE_DEVICE_* and EMBERWAVE_CONTEXT_KIND_* constants. Both C calls fill structs that carry their size (D69), whose first sizes the test of them pins. Claude-Session: https://claude.ai/code/session_019fJGoCTvP5e7n599q3ZQ42
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The additive items of #152:
Changes
Decoder::received_blocksandtotal_blocks.received_blocksandtotal_blocks, whichscripts/check_web.mjschecks.emberwave_decoder_receptionfills anEmberwaveReceptionwith the received and total blocks, and whether the start of frame header arrived.emberwave_context_infofills anEmberwaveContextInfo: the backend, the kind of device (EMBERWAVE_DEVICE_*), the PCI vendor and device, and which call made the context (EMBERWAVE_CONTEXT_KIND_*).struct_size(D69). The test of first sizes pins them: 24 and 16 bytes.ARCHITECTURE.md, the C README, andCHANGELOG.md.Testing
struct_sizeis refused.NULLcontext. The Metal test checks that a context on the app's queue says Metal and kind Metal.cargo test --release --workspaceon the M3 Max.scripts/build_web.shandnode scripts/check_web.mjs.Benchmark impact
None.
Review
A small additive change built on the struct helpers reviewed in #153, so it was not sent to the review agent.
Related issue
#152 (items 20 and 22).