Fix SmallCheckboxComponent not toggling upon a left click#452
Closed
TheVoidBlock wants to merge 1 commit intowisp-forest:1.21.9from
Closed
Fix SmallCheckboxComponent not toggling upon a left click#452TheVoidBlock wants to merge 1 commit intowisp-forest:1.21.9from
TheVoidBlock wants to merge 1 commit intowisp-forest:1.21.9from
Conversation
Author
|
Closes #444 |
Member
|
Does this really fix this issue? The |
Member
|
Superseded by #463 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug that causes the small checkbox component to not toggle when you click on it. Upon clicking the checkbox, the code checks if you left clicked with
click.isLeft(). Since Click extends AbstractInput,AbstractInput.isLeft()checks ifthis.getKeycode() == 263. Clicks implementation ofgetKeycode()returnsthis.button(), which will be 0 if the user left-clicked, NOT 263. To fix this, I simply check ifclick.button() == 0.