Skip to content

fix: missed files from previous release 0.48 #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skawaguchi-flipp wants to merge 3 commits into from
Closed

fix: missed files from previous release 0.48 #179

skawaguchi-flipp wants to merge 3 commits into from

Conversation

@skawaguchi-flipp
Copy link
Contributor

@skawaguchi-flipp skawaguchi-flipp commented Jul 28, 2025

No description provided.

@gitstream-cm
Copy link

gitstream-cm bot commented Jul 28, 2025

This PR is missing a Jira ticket reference in the title or description.
Please add a Jira ticket reference to the title or description of this PR.

@dorner
Copy link
Collaborator

dorner commented Jul 28, 2025

I'm confused... didn't the previous commit just change the action YAML file? What's up with all these changes?

@skawaguchi-flipp
deps: update to latest ncc, which uses OpenSSL 3 + npm updated lock
7229370 
- the versions we're using are quite old, and these were automatic updates
- also, I was forced to update the package-lock by whatever npm ships with Node 22, which is latest stable
@skawaguchi-flipp
fix: new files
2572649
@skawaguchi-flipp
Copy link
Contributor Author

skawaguchi-flipp commented Jul 28, 2025

Well, 0.48 didn't show up when I ran eks-deploy, so I ran the npm script from the README:

Please make sure to run npm run prepare before committing your files! You should probably add this to .git/hooks/pre-commit.

After creating a new minor patch version (ie v0.x), remember to update the major version tag to point to the latest patch.

That opened up a whole can of worms!

Is that not how we release any more?

@dorner
Copy link
Collaborator

dorner commented Jul 28, 2025

Only if we have to make changes to the main github action, which isn't really used much any more.

@skawaguchi-flipp
Copy link
Contributor Author

skawaguchi-flipp commented Jul 28, 2025

Looks like we don't use the main github, so this PR is irrelevant: #179 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbickfo dcbickfo Awaiting requested review from dcbickfo

@dorner dorner Awaiting requested review from dorner

Assignees

No one assigned

Labels

1 min review missing-jira

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skawaguchi-flipp @dorner