Repository navigation
Sync prd/ws-2 with upstream main and the final M2 - #8
Merged
Merged
Conversation
…tmocanu#4174) * fix(release): accept committed Codex adoption records Let scheduled RC planning accept a maintainer adoption assertion bound to regular lock and record blobs at the same pinned HEAD. Parse the strict digest and runtime tag without executing data; keep invalid assertions fail closed before the independent publication checks. Exclude assertions from pin sync, seed the reviewed 0.166.0 lock and update the release guidance and ADR. Cover committed, stale, malformed, untracked and symlink assertions, publication refusal, abandon and real pin sync. Fixes vtmocanu#4172. * fix(release): exclude adoption records from worker rolls Adoption assertions record release review and do not change worker execution. Exclude that exact path in the shared runtime diff and shipping classifier, so seeding or correcting an assertion preserves the decoupled worker pin. Exercise both record seeding and later edits through autobump check/edit modes. Keep similarly named Codex files and the actual runtime lock in the surface, with a lock edit still advancing the pin.
…#4173 M1) (vtmocanu#4175) * forge: split the Forge interface into IssueTracker and CodeHost (PRD vtmocanu#4173 M1) Forge becomes the union of two disjoint halves, each in its own file with the types only it uses: IssueTracker (issuetracker.go: issues, labels, comments, issue state) and CodeHost (codehost.go: everything else). forge.go keeps the package-wide pieces (Type, RateLimitError, the sentinels, New) and the identity types Project and BotIdentity. Pure moves: no method, signature or caller changes. The three drivers and forgetest.BaseFake still implement Forge; the per-half var _ lines next to each driver are readable markers only. Adds prds/4173-external-issue-trackers.md. Co-Authored-By: uzi-agent <uzi-agent@uzi.local> Co-Authored-By: Claude <noreply@anthropic.com> * docs: PRD vtmocanu#4173 says issue tracker throughout and settles its open points - Terminology: "issue tracker", never the bare "tracker"; the driver package is named api/internal/issuetracker. - The withdrawal, comment/command and outbox gaps from the scope review are listed under Out of scope for the follow-up PRDs. - The Open questions section goes: identity and comment-author mapping are decided in M4 and recorded in the Decision Log before code; bot-assignment eligibility is not offered in this PRD. Changelog: none Co-Authored-By: Claude <noreply@anthropic.com> * docs: ARCHITECTURE.md cites PRD vtmocanu#4173 for the caller rule Changelog: none Co-Authored-By: Claude <noreply@anthropic.com> * docs: PRD vtmocanu#4173 adds the link/relink policy and the secret-scan gate Review findings on the PR: - D13: an issue number belongs to one issue source. Runs and cached issues record their source, a repo changes source only when idle, and lifecycle or MR-watcher updates never act on the same number in another source. M4's acceptance covers the transition. - Every milestone's gate names task scan:secrets and requires the canaries-detected line in the run's evidence. Changelog: none Co-Authored-By: Claude <noreply@anthropic.com> * docs: PRD vtmocanu#4173 D13 fences a source change against in-flight operations A per-repo issue-source generation guards sync results, and a per-repo lock makes a source change wait for issue writes in flight. M4's acceptance adds the two concurrent cases. Changelog: none Co-Authored-By: Claude <noreply@anthropic.com> * docs: PRD vtmocanu#4173 D13 states one per-repo fence for every source-dependent operation Run creation, sync and issue writes through their cache update complete against the source they resolved or are refused; the mechanism is M4's choice. M4's acceptance lists the concurrent cases. Changelog: none Co-Authored-By: Claude <noreply@anthropic.com> * docs: PRD vtmocanu#4173 r4 after the maintainer's review of M1 Decide the YouTrack id adapter (D10), the eligibility tag by id (D14) and the issue-author policy (D11) before the M3 driver. Fix a repo's issue source before its first enable instead of fencing relinks (D13). Run the contract suite on the real drivers (D7), wire the allowlist through the chart and compose in M3, move the ADR to M3, and state the in-run test boundary, the E2E sweep and hosted Kubernetes verification. Co-Authored-By: Claude <noreply@anthropic.com> * docs: PRD vtmocanu#4173 D10 and D14 wording from review Connection operations need no project; the eligibility label always resolves to the stored tag id. Co-Authored-By: Claude <noreply@anthropic.com> * docs: PRD vtmocanu#4173 second review pass Every repo existing at the M4 migration counts as previously enabled (D13). The driver refuses a projectID other than its own and listing states is project-scoped (D10). The eligibility tag is checked through its see and use settings, read-only (D14). No number is derived from a comment id (D10). Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Mircea Tufan <MirceaTufanDev@users.noreply.github.com> Co-authored-by: uzi-agent <uzi-agent@uzi.local> Co-authored-by: Claude <noreply@anthropic.com>
GetIssueBounded takes IssueTracker; BuildFailureSnapshot and privcheck take CodeHost; comment intake (issueinput.Fetch) takes (ch, tr). provisionsvc.Guard follows privcheck. Callers pass the driver as both halves; test edits are fake parameter types and f -> f, f only. Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sync, board moves, close/reopen and the card-move interfaces take IssueTracker; pipeline sync, board-free MR watch, merged-predecessor and project-scope checks take CodeHost; the MR state watcher and PRD link patch take (ch, tr). New repo_sides.go resolves a repo's two sides (D8); both return the forge driver in this PRD. Test edits are fake parameter types and f -> f, f only. Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settle, prerequisite-closure, publication-proof, CI-fix binding and self-improve MR reads go through CodeHost; semantic drift, proposal filing and task continuation issue reads go through IssueTracker. The connection factory interface still returns the union. Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI watch, CI scout and artifact collection take CodeHost; the self-improve tracking issue and proposal digest go through IssueTracker. Self-improve still builds one driver and hands each call the half it needs. Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fireCIWatch reads workflow runs through a CodeHost local; fireSelfImprove keeps its single build and reads MRs through CodeHost and files the tracking issue through IssueTracker (plan U3b; review N1/N2). Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Autopilot, CI autofix and MR rework detection take the code host and issue tracker as two parameters: label events, comments and comment intake on the issue side; CI config, failure snapshots, MR comments and author eligibility on the code side. The poll loop still builds one driver and passes it as both halves. Test edits are f -> f, f call sites plus four inline fakes hoisted into locals. Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Repo-scoped handlers resolve the half they need through new issueTrackerForRepo/codeHostForRepo wrappers (forgesvc IssueTrackerForRepo/CodeHostForRepo, keeping the forgeFactory test hook): issue creation, labels, board columns, moves, promote and sync on the issue tracker; pulls, CI runs, CI fix and MR rework on the code host. Connection-scoped handlers and the worker forge routes keep one build and narrow at each use; the worker get-issue route uses both. Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every caller moved to issueTrackerForRepo/codeHostForRepo in the previous commit, so forgeForConnection is dead. The forgeFactory and wrapper doc comments now describe the wrappers as the only path (U3d review N1-N3). Changelog: none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Tick M2, refresh the Current state anchors and the inventory of issue-side calls against main, record the M2 decisions, and state that the projectID guard needs the owner-scoped resolver for two connections exposing the same forge project number (D10, tested in M4). Co-Authored-By: uzi-agent <uzi-agent@uzi.local> Co-Authored-By: Claude <noreply@anthropic.com>
The last four code-host calls made on a forge.Forge value now go through CodeHost, and board-column setup takes the IssueTracker half (PRD vtmocanu#4173 D3). The inventory shows no call through the union. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Takes the tree of 4173-m2-every-caller-on-its-half: upstream main (with M1 and the reviewed PRD merged) plus M2 as sent upstream. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the integration branch to the state sent upstream.
mainas of today, which already contains M1 and the reviewed PRD.provisionsvcandseednarrowing the driver before use, and the PRD with M2 ticked and the anchors refreshed.The resulting tree is identical to the branch
4173-m2-every-caller-on-its-half. 15 files differ from the currentprd/ws-2.Merge with a merge commit (not squash), so the upstream history stays an ancestor.
🤖 Generated with Claude Code