6. Example PackingProblem: Misc fixes and improvements#3
Open
Th3Fanbus wants to merge 6 commits intowisaaco:mainfrom
Open
6. Example PackingProblem: Misc fixes and improvements#3Th3Fanbus wants to merge 6 commits intowisaaco:mainfrom
Th3Fanbus wants to merge 6 commits intowisaaco:mainfrom
Conversation
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Remove unnecessary variables, make naming consistent, fix stdout messages getting mixed up, add several comments and add a note about optimisation showing that manual optimisations are not always good. Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Array lengths are best expressed using `size_t` instead of `int`. Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Templatise the map, scan and filter functions so that they can be used with any compatible type, and introduce a few more templatised helpers to (hopefully) make the code more elegant. This also overhauls printing vectors so that columns are aligned. This makes it easier to correlate values from various vectors. Finally, add several comments to explain how the program works. Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see individual commit messages for more information.