Moving Scenario state change before global response delay is set#1436
Open
jayaraman-venkatesan wants to merge 2 commits intowiremock:masterfrom
Open
Moving Scenario state change before global response delay is set#1436jayaraman-venkatesan wants to merge 2 commits intowiremock:masterfrom
jayaraman-venkatesan wants to merge 2 commits intowiremock:masterfrom
Conversation
Author
|
@StefH The windows tests seems to be flaky, any help reruning it would be appreciated |
Author
|
Thanks for re-running @StefH It failed at adminmapping test, but Admin routes never have a Scenario set — so the moved code is completely bypassed for any POST /__admin/mappings request. my change should not have effect on admin API routing. Can you help looking into it or help re-running it once more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the change of scenario state change before global response delay so that subsequent retries arriving during a delay period see the updated state and match the correct next mapping instead of re-matching same old one.
References
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java