Skip to content

Moving Scenario state change before global response delay is set#1436

Open
jayaraman-venkatesan wants to merge 2 commits intowiremock:masterfrom
jayaraman-venkatesan:bug/wiremock-1260
Open

Moving Scenario state change before global response delay is set#1436
jayaraman-venkatesan wants to merge 2 commits intowiremock:masterfrom
jayaraman-venkatesan:bug/wiremock-1260

Conversation

@jayaraman-venkatesan
Copy link
Copy Markdown

Moved the change of scenario state change before global response delay so that subsequent retries arriving during a delay period see the updated state and match the correct next mapping instead of re-matching same old one.

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@jayaraman-venkatesan jayaraman-venkatesan changed the title [ISSUE-1268] bug/wiremock-1268 moving Scenario state change before global response delay is set [#ISSUE-1268] bug/wiremock-1268 moving Scenario state change before global response delay is set Mar 31, 2026
@jayaraman-venkatesan jayaraman-venkatesan changed the title [#ISSUE-1268] bug/wiremock-1268 moving Scenario state change before global response delay is set [#ISSUE-1260] bug/wiremock-1268 moving Scenario state change before global response delay is set Mar 31, 2026
@jayaraman-venkatesan
Copy link
Copy Markdown
Author

jayaraman-venkatesan commented Mar 31, 2026

@StefH The windows tests seems to be flaky, any help reruning it would be appreciated

@StefH StefH added the feature label Mar 31, 2026
@StefH StefH changed the title [#ISSUE-1260] bug/wiremock-1268 moving Scenario state change before global response delay is set Moving Scenario state change before global response delay is set Mar 31, 2026
@jayaraman-venkatesan
Copy link
Copy Markdown
Author

jayaraman-venkatesan commented Apr 1, 2026

Thanks for re-running @StefH
but it failed in different step, which again i suspect is because of parallelized tests

It failed at adminmapping test, but Admin routes never have a Scenario set — so the moved code is completely bypassed for any POST /__admin/mappings request. my change should not have effect on admin API routing.

Can you help looking into it or help re-running it once more?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants