feat(lgbm): support string features via pandas categorical#15
Open
feat(lgbm): support string features via pandas categorical#15
Conversation
cp2587
requested changes
Mar 14, 2022
aywandji
force-pushed
the
support-string-features-gbm
branch
from
9ea0ead to
737794b
Compare
cp2587
reviewed
Mar 15, 2022
aywandji
force-pushed
the
support-string-features-gbm
branch
from
737794b to
7e07e25
Compare
aywandji
force-pushed
the
support-string-features-gbm
branch
from
7e07e25 to
12d4677
Compare
Contributor
|
I let @crqs merge this as he recently worked on this project to make sure the inference performances were good enough: i want him to know of this so he can backtrack if performance deteriorate. also as discussed, we should see if the python code and loop can be replaces by something else as it has maybe an huge impact on inference times |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add logic to convert string features to int (using lightgbm model pandas categoricals) before prediction