Feat/implement multi database support#42
Conversation
53ec507 to
6aba485
Compare
dac9a0a to
775731e
Compare
775731e to
00c57b1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements multi-database migration support for Chartreuse, allowing management of migrations across multiple databases simultaneously while maintaining backward compatibility with the existing single-database configuration.
- Adds YAML-based configuration for multiple databases with automatic URL building from components
- Introduces
MultiChartreuseclass to handle multiple database migrations - Updates CLI to support both legacy single-database and new multi-database modes
Reviewed Changes
Copilot reviewed 24 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/chartreuse/utils/alembic_migration_helper.py | Updated string formatting to use f-string syntax |
| src/chartreuse/config_loader.py | New module for loading and validating multi-database YAML configurations |
| src/chartreuse/chartreuse.py | Added MultiChartreuse class for handling multiple database migrations |
| src/chartreuse/chartreuse_upgrade.py | Enhanced main function to support both single and multi-database modes |
| setup.py | Added PyYAML dependency for YAML configuration parsing |
| pyproject.toml | Migrated from legacy setup.py configuration to modern pyproject.toml |
| scripts/validate_config.py | New configuration validation script for multi-database setups |
| docs/multi-database.md | Comprehensive documentation for the new multi-database feature |
| example/ | Added example configuration files demonstrating multi-database usage |
| VERSION | Bumped version to 6.0.0 for this major feature addition |
| tests/ | Extensive test coverage for new functionality and updated existing tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
deeccdb to
4d34f9e
Compare
…mbic.ini file substituion
4d34f9e to
747710d
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 38 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/chartreuse/tests/unit_tests/test_chartreuse_upgrade_extended.py
Outdated
Show resolved
Hide resolved
638d080 to
1dc5e76
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 38 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zapaan
left a comment
There was a problem hiding this comment.
We should discuss about the config style and the alembic_migration_helper
a7cab5d to
1636c78
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 33 out of 39 changed files in this pull request and generated 8 comments.
Comments suppressed due to low confidence (1)
src/chartreuse/tests/unit_tests/test_config_loader.py:1
- Use 'Any' from typing module instead of lowercase 'any'. The correct type annotation should be 'list[dict[str, Any]]'.
"""
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1636c78 to
6986a94
Compare
3829e48 to
5728b19
Compare
example/helm-chart/my-example-chart/charts/chartreuse-5.0.3.tgz
Outdated
Show resolved
Hide resolved
5728b19 to
d44c422
Compare
No description provided.