Skip to content

Feat/implement multi database support#42

Merged
nahuel11500 merged 13 commits intomainfrom
feat/implement-multi-database-support
Oct 10, 2025
Merged

Feat/implement multi database support#42
nahuel11500 merged 13 commits intomainfrom
feat/implement-multi-database-support

Conversation

@nahuel11500
Copy link
Contributor

No description provided.

@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch 4 times, most recently from 53ec507 to 6aba485 Compare October 7, 2025 13:32
@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch 6 times, most recently from dac9a0a to 775731e Compare October 7, 2025 13:48
@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch from 775731e to 00c57b1 Compare October 7, 2025 14:36
@nahuel11500 nahuel11500 requested a review from Copilot October 7, 2025 14:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements multi-database migration support for Chartreuse, allowing management of migrations across multiple databases simultaneously while maintaining backward compatibility with the existing single-database configuration.

  • Adds YAML-based configuration for multiple databases with automatic URL building from components
  • Introduces MultiChartreuse class to handle multiple database migrations
  • Updates CLI to support both legacy single-database and new multi-database modes

Reviewed Changes

Copilot reviewed 24 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/chartreuse/utils/alembic_migration_helper.py Updated string formatting to use f-string syntax
src/chartreuse/config_loader.py New module for loading and validating multi-database YAML configurations
src/chartreuse/chartreuse.py Added MultiChartreuse class for handling multiple database migrations
src/chartreuse/chartreuse_upgrade.py Enhanced main function to support both single and multi-database modes
setup.py Added PyYAML dependency for YAML configuration parsing
pyproject.toml Migrated from legacy setup.py configuration to modern pyproject.toml
scripts/validate_config.py New configuration validation script for multi-database setups
docs/multi-database.md Comprehensive documentation for the new multi-database feature
example/ Added example configuration files demonstrating multi-database usage
VERSION Bumped version to 6.0.0 for this major feature addition
tests/ Extensive test coverage for new functionality and updated existing tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch 2 times, most recently from deeccdb to 4d34f9e Compare October 8, 2025 15:03
@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch from 4d34f9e to 747710d Compare October 8, 2025 15:05
@nahuel11500 nahuel11500 requested a review from Copilot October 8, 2025 15:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 32 out of 38 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch from 638d080 to 1dc5e76 Compare October 8, 2025 15:45
@nahuel11500 nahuel11500 requested a review from Copilot October 8, 2025 15:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 32 out of 38 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nahuel11500 nahuel11500 self-assigned this Oct 8, 2025
@nahuel11500 nahuel11500 requested a review from zapaan October 8, 2025 16:00
Copy link

@zapaan zapaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss about the config style and the alembic_migration_helper

@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch 3 times, most recently from a7cab5d to 1636c78 Compare October 9, 2025 13:47
@nahuel11500 nahuel11500 requested review from Copilot October 9, 2025 13:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 33 out of 39 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

src/chartreuse/tests/unit_tests/test_config_loader.py:1

  • Use 'Any' from typing module instead of lowercase 'any'. The correct type annotation should be 'list[dict[str, Any]]'.
"""

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch from 1636c78 to 6986a94 Compare October 9, 2025 14:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@nahuel11500 nahuel11500 requested a review from zapaan October 9, 2025 15:26
@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch 2 times, most recently from 3829e48 to 5728b19 Compare October 9, 2025 16:03
@arthlr arthlr self-requested a review October 10, 2025 08:46
Copy link

@arthlr arthlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nahuel11500 nahuel11500 force-pushed the feat/implement-multi-database-support branch from 5728b19 to d44c422 Compare October 10, 2025 09:11
@nahuel11500 nahuel11500 merged commit 784c9c4 into main Oct 10, 2025
5 checks passed
@nahuel11500 nahuel11500 deleted the feat/implement-multi-database-support branch October 10, 2025 09:40
@zapaan zapaan mentioned this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants