[WPB-22549] Integration tests: output request also in curl syntax.#5028
Open
[WPB-22549] Integration tests: output request also in curl syntax.#5028
Conversation
supersven
reviewed
Feb 13, 2026
| submit method req0 = do | ||
| let req = req0 {HTTP.method = T.encodeUtf8 (T.pack method)} | ||
| -- uncomment this for more debugging noise: | ||
| -- liftIO $ putStrLn $ requestToCurl req |
Contributor
There was a problem hiding this comment.
I'm wondering if if wouldn't be beneficial to toggle this with e.g. a flag make ci-[fast|slow] noisy=1 🤔
(Commented code is usually subject to "bit rot".)
Contributor
Author
There was a problem hiding this comment.
yeah, but i also didn't want to mess with the UI. should i remove it then?
Contributor
There was a problem hiding this comment.
I would argue that once you arrived there, the commented code is quickly written... However, tastes differ. I don't object.
supersven
reviewed
Feb 13, 2026
integration/test/Testlib/Types.hs
Outdated
|
|
||
| requestToCurl :: HTTP.Request -> String | ||
| requestToCurl req = | ||
| intercalate " " $ -- TODO: amke this multi-line, but so thhhaaaatttt iiiitttt ddddoooesn't go wrong. |
Contributor
There was a problem hiding this comment.
Is this still to do? A FUTUREWORK-improvement?
fisx
commented
Feb 13, 2026
supersven
added
the
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a small thing i found useful when working on the other ticket.
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d