Open
Conversation
supersven
approved these changes
Feb 13, 2026
fisx
approved these changes
Feb 13, 2026
pcapriotti
force-pushed
the
history-permission
branch
2 times, most recently
from
71e22c2 to
ebf282e
Compare
This broke API compatibility. Instead, reuse ModifyConversationAccess action permission. Permissions are only used internally and don't really affect the behaviour of the backend, anyway.
pcapriotti
force-pushed
the
history-permission
branch
from
ebf282e to
b0d0788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When history metadata was introduced, we added a new
ModifyConversationHistoryconstructor for theActiontype, corresponding to the permission of modifying the conversation history settings.However, this broke API compatibility, since we are returning a list of permissions in a conversation endpoint.
This PR reuses the
ModifyConversationAccessaction permission instead. Permissions are only used internally and don't really affect the behaviour of the backend, anyway.Checklist
changelog.d