Conversation
fisx
added
the
not-ok-to-test
|
@fisx I'm wondering how this PR can be |
i see it as a parallel thing: PR needs a positive review and green from CI, in any order. but you may decide to wait for CI, of course. :-) (or am i being annoying?) |
fisx
force-pushed
the
WPB-22549-add-type-field-to-user
branch
from
7b325e9 to
c22d053
Compare
fisx
added
ok-to-test
| @@ -0,0 +1 @@ | |||
| Cassandra (`brig.user`) now keeps track of user types, only for newly created users. **Read this paragraph if you have already created apps before their official support:** For existing users and bots, the user type is inferred, but existing apps will show as regular users. Please remove those users from your team and create them again. | |||
There was a problem hiding this comment.
Sorry, I know too little about apps: Is the audience of the changelog the same as the people adding apps? (I.e. sys admins deploying Wire?)
There was a problem hiding this comment.
changelog should be read by everybody who is dealing with wire-server i guess, so yes, team admins adding apps are covered?
of in this case: the site admin should read this and then make sure nobody is using any apps in prod already (which they shouldn't, it hasn't been released yet).
| 1 -> pure UserTypeBot | ||
| 2 -> pure UserTypeApp | ||
| n -> Left $ "unexpected user type: " ++ show n | ||
| fromCql _ = Left "user type: int expected" |
There was a problem hiding this comment.
Have you considered to add the unbound value (_) to the error message? Maybe, it could be helpful in case this goes wrong and needs to be debugged?
There was a problem hiding this comment.
i would, but it's like this in all the other cql instances, and i've just go CI green... :-)
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
Besides my nitpicks, LGTM 👍
2 participants
https://wearezeta.atlassian.net/browse/WPB-22549
Checklist
changelog.d