WPB-18320 make hardcoded images in helm charts configurable via values yaml#5015
Conversation
zebot
added
the
ok-to-test
There was a problem hiding this comment.
Pull request overview
Updates several Helm charts to avoid hardcoded container image references by moving them into values.yaml, so operators can override repositories/tags without patching templates.
Changes:
legalhold: introduceimage.repository/image.tagvalues and use them in the Deployment template.fake-aws-sns/fake-aws-ses: add configurableawsCliImage.repository/awsCliImage.tagfor the AWS CLI sidecar/init container.demo-smtp: switch from a singleimagestring toimage.repository/image.tag(values schema change).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/legalhold/values.yaml | Adds image.repository and image.tag defaults. |
| charts/legalhold/templates/deployment.yaml | Uses the new image.* values instead of a hardcoded image. |
| charts/fake-aws-sns/values.yaml | Adds awsCliImage.* defaults for the AWS CLI container image. |
| charts/fake-aws-sns/templates/deployment.yaml | Uses awsCliImage.* in the deployment template. |
| charts/fake-aws-ses/values.yaml | Adds awsCliImage.* defaults for the AWS CLI container image. |
| charts/fake-aws-ses/templates/deployment.yaml | Uses awsCliImage.* in the deployment template. |
| charts/demo-smtp/values.yaml | Changes image from string to image.repository/image.tag. |
| charts/demo-smtp/templates/deployment.yaml | Updates template to use image.repository/image.tag. |
| changelog.d/5-internal/WPB-18320 | Adds changelog entry for the Helm image configurability work. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| image: | ||
| repository: quay.io/wire/ixdotai-smtp | ||
| tag: v0.5.2 |
There was a problem hiding this comment.
demo-smtp changes .Values.image from a string (e.g. quay.io/...:tag) to a map with repository/tag. This is a breaking values-schema change for anyone overriding the chart via --set image=... or an existing values file. Consider keeping backward compatibility in the template by accepting both forms (string or map) and only using image.repository/image.tag when those keys are present.
| image: | |
| repository: quay.io/wire/ixdotai-smtp | |
| tag: v0.5.2 | |
| image: quay.io/wire/ixdotai-smtp:v0.5.2 |
There was a problem hiding this comment.
Not sure if this is really relevant? WDYT @lwille ?
| containers: | ||
| - name: {{ .Chart.Name }} | ||
| image: "{{ .Values.image }}" | ||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" |
There was a problem hiding this comment.
This template now assumes .Values.image is a map with repository/tag. If a user still provides image as a single string (previous behavior), Helm rendering will fail with a type error. Consider rendering the image using a conditional that supports both a string value and the new map form.
| @@ -0,0 +1 @@ | |||
| Made hard coded images in helm charts configurable | |||
There was a problem hiding this comment.
The changelog entry is very generic, but this PR includes a breaking values-schema change for demo-smtp (switching image from string to image.repository/image.tag). Consider noting that explicitly so downstream users know their existing overrides may need to be updated.
| Made hard coded images in helm charts configurable | |
| Made hard coded images in helm charts configurable; BREAKING: for the `demo-smtp` chart, the values schema changed from a single `image` string to `image.repository` and `image.tag`, so existing image overrides must be updated. |
2 participants
https://wearezeta.atlassian.net/browse/WPB-18320
Checklist
changelog.d