Skip to content

refactor: previews not building for network screen because of cotext usage [WPB-23588]#4603

Open
MohamadJaara wants to merge 2 commits intodevelopfrom
mo/refactor/have-network-settings-screen-build-previews
Open

refactor: previews not building for network screen because of cotext usage [WPB-23588]#4603
MohamadJaara wants to merge 2 commits intodevelopfrom
mo/refactor/have-network-settings-screen-build-previews

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Feb 18, 2026

https://wearezeta.atlassian.net/browse/WPB-23588


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

network settings screen preview not rendering and the ViewModel have no tests

Solutions

refactor it to not use the app context this fixed the preview
add tests to the ViewModel

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link

@MohamadJaara MohamadJaara changed the title refactor: previews not building for network screen because of cotext usage refactor: previews not building for network screen because of cotext usage ["WPB-23588"] Feb 18, 2026
@MohamadJaara MohamadJaara changed the title refactor: previews not building for network screen because of cotext usage ["WPB-23588"] refactor: previews not building for network screen because of cotext usage [WPB-23588] Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments