Repository navigation
Match role and group names exactly - #7
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 7 7
Lines 496 496
=======================================
Hits 479 479
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Role names contain each other, so a substring match made the shorter name of such a pair ambiguous however completely it was written out, leaving no way to activate that role at all. Names are now matched in full, case-insensitively. A name can still match more than one assignment, since a group held as both member and owner has the same name twice, so the ambiguity error stays.
winebarrel
force-pushed
the
exact-name-match
branch
from
August 31, 2026 02:35
9504876 to
e1239fe
Compare
winebarrel
enabled auto-merge
August 31, 2026 02:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activating a role whose display name is contained in another eligible role's display name was impossible: names were matched with a case-insensitive substring test, so even writing the shorter name out in full matched both roles and failed as ambiguous.
Names are now matched in full, case-insensitively (
strings.EqualFold). The ambiguity error stays for the case that is genuinely ambiguous: a group held as both member and owner has the same name twice, which--accessresolves.Short queries such as
azpim role activate "reader"no longer match a longer name; the full display name is required.