fix(ci): serialize Play deploy and listing sync into one edit group - #75
Merged
Conversation
The icon merge pushed both an android/app mipmap change (triggers Deploy to Play Store) and a fastlane listing image (triggers Sync Store Listings). Both ran at 21:58:31 and both call upload_to_play_store, but they were in separate concurrency groups so they opened Google Play edit transactions simultaneously. When the AAB deploy committed its edit, the Play API invalidated the listing sync's edit: Google Api Error: Invalid request - This Edit has been deleted. Put both Play-editing paths in a shared 'play-publisher-edit' concurrency group (job-level on play-listing so the iOS listing job is unaffected) so only one Play edit is ever open. The listing sync now queues behind the deploy instead of racing it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Merging the new app icon (#74) pushed two changes at once:
android/app/src/main/res/mipmap-*/ic_launcher.png→ triggers Deploy to Play Store (fastlane beta)android/fastlane/metadata/android/en-US/images/icon.png→ triggers Sync Store Listings (fastlane listing)Both started at the same second and both call
upload_to_play_store, but they lived in separate concurrency groups (playstore-deployvsstorelisting), so they opened Google Play edit transactions concurrently. The Play Publishing API allows only one open edit per app — when the AAB deploy committed, it deleted the listing sync's edit:The AAB deploy + TestFlight both succeeded; only the listing sync failed.
Fix
Both Play-editing paths now share the
play-publisher-editconcurrency group (cancel-in-progress: false), so the listing push queues behind the AAB deploy instead of racing it. Job-level onplay-listingso the iOSappstore-listingjob (App Store Connect, separate API) is unaffected. No deadlock: the deploy never waits on thestorelistinggroup, so it can always run and release the shared slot.Merging this re-triggers both workflows; this time they serialize and the listing icon finally lands.
🤖 Generated with Claude Code