fix(discover): decode recommendations from the backend's nullable 'reason' - #81
Merged
Conversation
…ason' The model required a 'reasoning' JSON key, but the backend serves the field as nullable 'reason' (schemas/feed.py RecommendationOut) — every discover response threw "type 'Null' is not a subtype of type 'String'" and the Explore tab showed the error card instead of suggestions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015UjT16Qz6fmtx8UYzE9pfY
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Recommendation model required a
reasoningJSON key, but the backend serves the field as nullablereason(schemas/feed.pyRecommendationOut). EveryGET /api/discoverresponse failed to decode withtype 'Null' is not a subtype of type 'String', so the Explore tab rendered its error card instead of suggestions.Maps the field with
@JsonKey(name: 'reason')and defaults it to''so a null reason can't break the whole payload. The Dart-sidereasoningname (and all call sites/tests) are unchanged.Found while generating store screenshots against the nullfeed-demo server, which mirrors the real backend's shape.
🤖 Generated with Claude Code
https://claude.ai/code/session_015UjT16Qz6fmtx8UYzE9pfY