feat(v0.3.0): metadata namespace redesign (BREAKING)#9
Merged
Conversation
… reject old shape
- lookup_file.yaml: point to stub CSV asset (was referencing a non-existent path) - rtr_put_file.yaml: rename source -> file_path (correct schema field) + stub XML - workflow.yaml: replace synthetic placeholder with minimal valid trigger+actions Surfaced by the v0.3.0 example-parity test. No metadata/ads migrations were needed on any example except detection.yaml (Task 13).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata:namespace on every resource type, stripped from API payloads and content hashes (closes the issue **dashboard apply fails: "_template_path" leaks into Humio payload (+ design Q: metadata namespace)** #7 bug class for all providers, not just dashboard).metadata.maturity:validation runs universally;metadata.ads:is detection-only; third-party sub-namespaces (metadata.<any>) pass through unvalidated but guaranteed never to leak to the CrowdStrike/Humio API.ads:, flatmetadata:) with a migration pointer referencing CHANGELOG.md.Breaking changes
ads:or flatmetadata: {created, tune_count, …}at the root now failtalonctl validatewith a migration-pointer error. Users migrate by hand (mechanical rule in CHANGELOG); notalonctl migratecommand ships.Changes
core/metadata_validators.py(new):validate_maturity()+reject_old_shape().core/template_sanitizer(shipped in v0.2.1).examples/resources/detection.yamlmigrated to nested shape. Three other examples (lookup_file, rtr_put_file, workflow) had pre-existing validation bugs; these are fixed so the new parity test can enforce real schema compliance.Test plan
pytest tests/— 542 passed (was 491 before this branch)ruff format --check src/ tests/— cleanruff check src/ tests/— cleanads:or flatmetadata:remain inexamples/orsrc/talonctl/templates/tests/unit/test_metadata_validators.py— 30 tests for shared validatorstests/unit/test_old_shape_rejection.py— 14 parametrized tests locking the migration-pointer string across all 7 providerstests/unit/test_examples.py— parity test validating every reference YAMLtalonctl planon a v0.3.0-migrated project shows NO_CHANGE when onlymetadata.*fields change (requires work environment — side-project has no API access)Plan:
docs/superpowers/plans/2026-04-16-metadata-namespace-redesign-plan.md🤖 Generated with Claude Code