You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Changes the selection logic for bulk mute/pin/unpin/snooze to apply current search/filter criteria, which could unintentionally include/exclude events if matching logic is wrong. Also moves pin updates in ViewEventActivityNoRecents to a background thread, which may introduce ordering/race issues with UI state vs DB writes.
Overview
Bulk actions now respect the current search query and active filters: muteAllVisibleEvents, pinAllVisibleEvents, unpinAllVisibleEvents, and snoozeAllEvents route their per-event checks through a new shared matcher FilterState.matchesSearchAndFilters() (plus FilterState.matchesEvent()), so operations apply only to what the user is currently viewing.
The main menu/confirmation copy is updated to reflect filtered vs unfiltered bulk actions (new …_filtered strings and dynamic menu titles/messages). Pin/unpin from ViewEventActivityNoRecents is changed to update the in-memory event immediately and persist the DB change asynchronously. Unit tests were extended to cover filter/search-aware bulk mute/pin/unpin behavior.
Reviewed by Cursor Bugbot for commit a07c51c. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
williscool
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Note
Medium Risk
Changes the selection logic for bulk mute/pin/unpin/snooze to apply current search/filter criteria, which could unintentionally include/exclude events if matching logic is wrong. Also moves pin updates in
ViewEventActivityNoRecentsto a background thread, which may introduce ordering/race issues with UI state vs DB writes.Overview
Bulk actions now respect the current search query and active filters:
muteAllVisibleEvents,pinAllVisibleEvents,unpinAllVisibleEvents, andsnoozeAllEventsroute their per-event checks through a new shared matcherFilterState.matchesSearchAndFilters()(plusFilterState.matchesEvent()), so operations apply only to what the user is currently viewing.The main menu/confirmation copy is updated to reflect filtered vs unfiltered bulk actions (new
…_filteredstrings and dynamic menu titles/messages). Pin/unpin fromViewEventActivityNoRecentsis changed to update the in-memory event immediately and persist the DB change asynchronously. Unit tests were extended to cover filter/search-aware bulk mute/pin/unpin behavior.Reviewed by Cursor Bugbot for commit a07c51c. Bugbot is set up for automated code reviews on this repo. Configure here.